Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Try to improve under_cached_property performance (another way) #64

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 23, 2024

No description provided.

@bdraco
Copy link
Member Author

bdraco commented Oct 23, 2024

The job running on runner GitHub Actions 6 has exceeded the maximum execution time of 1 minute.

@bdraco bdraco closed this Oct 23, 2024
@bdraco bdraco reopened this Oct 23, 2024
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #64 will not alter performance

Comparing another_way_2 (73c7bc1) with master (b7be10f)

Summary

✅ 2 untouched benchmarks

@bdraco bdraco closed this Oct 23, 2024
@bdraco bdraco deleted the another_way_2 branch October 23, 2024 01:37
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (b7be10f) to head (73c7bc1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   88.52%   88.50%   -0.02%     
==========================================
  Files          18       18              
  Lines         697      696       -1     
  Branches       70       70              
==========================================
- Hits          617      616       -1     
  Misses         62       62              
  Partials       18       18              
Flag Coverage Δ
CI-GHA 88.50% <100.00%> (-0.02%) ⬇️
MyPy 77.48% <ø> (ø)
OS-Linux 99.37% <100.00%> (-0.01%) ⬇️
OS-Windows 94.71% <ø> (ø)
OS-macOS 95.29% <100.00%> (-0.02%) ⬇️
Py-3.10.11 94.98% <100.00%> (-0.02%) ⬇️
Py-3.10.15 97.49% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.49% <100.00%> (-0.01%) ⬇️
Py-3.11.9 94.98% <100.00%> (-0.02%) ⬇️
Py-3.12.7 97.49% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.49% <100.00%> (-0.01%) ⬇️
Py-3.9.13 94.96% <100.00%> (-0.02%) ⬇️
Py-3.9.20 97.48% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.81% <ø> (ø)
Py-pypy7.3.17 96.83% <ø> (ø)
VM-macos-latest 95.29% <100.00%> (-0.02%) ⬇️
VM-ubuntu-latest 99.37% <100.00%> (-0.01%) ⬇️
VM-windows-latest 94.71% <ø> (ø)
pytest 99.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant